For the hell of it (and because it looks like it isn’t currently being maintained) I started having a look at what it would take to update sedlex to use Uchar.t instead of int to represent unicode characters, and perhaps changing it to use @dbuenzli ’s Unicode libraries instead of handling all the un…

In this case, I would say: Call it 2.0 and break compat. Sometimes, that’s the right thing to do. :slight_smile: Side note: as someone with commit rights on sedlex, I would support this change.

So just to be clear, in this case, you are suggesting picking option (1), and the bump of the major version number would have human and opam effects only. Do I have that right?

Apparently I can’t have discuss messages less than 20 chars, so: Yes.

Cool, thank you. And I may submit a pull request at some point soon to sedlex. I presume that’s the preferred method? BTW, as an aside, there seem like a couple pull requests (like one for some code better menhir integration) queued up. (I have not looked to see if either of them are sane, so don’t…

I have no idea if @alainfrisch would even care for my changes in the first place I will certainly not oppose the change, and if Drup supports it, there is a good chance it goes in. The situation with respect to me not-supporting sedlex: I’ve written it as a toy POC for the ppx “technology” – I t…

[image] alainfrisch: The situation with respect to me not-supporting sedlex: I’ve written it as a toy POC for the ppx “technology” – I think it was the first publicly available ppx – but I’ve never used it for any project at all. I’d be happy to completely hand over maintenance of the project. …

[image] perry: What’s the best practice for dealing with such a large change in a public library with a bunch of downstream users? I love the way Lwt handles this (#453) . They open an issue listing the planned changes along with several dedicated issues (e.g. #441 ) for tracking each, come up …

FYI, work in progress is here: [image] pmetzger/sedlex An OCaml lexer generator for Unicode. Contribute to pmetzger/sedlex development by creating an account on GitHub. Note that my changes to the ppx rewriter aren’t quite baked, but it does work.

Best practices for large API changes?

Learning

perry November 24, 2017, 2:31am 9

FYI, work in progress is here:

Note that my changes to the ppx rewriter aren’t quite baked, but it does work.

Topic		Replies	Views
Sedlex moved to ocaml-community Ecosystem	15	2368	September 11, 2018
[ANN] Sedlex 3.2 Ecosystem announce , ppx , unicode , sedlex	0	529	June 30, 2023
Sedlex (why not ocamllex?) Ecosystem sedlex , ocamllex	2	1543	March 26, 2021
The end of Camlp4 Community announce , ppx	95	9000	May 27, 2020
Breaking PPX API changes and the package ecosystem Ecosystem	17	1007	September 5, 2025

Best practices for large API changes?

Related topics