RList.cons silently fails in JS

Ecosystem
,
21

Can you try the following fix Lib: fix 1352 by hhugo · Pull Request #1353 · ocsigen/js_of_ocaml · GitHub

1 Like
22

Hi, sorry for the delay. Your fix works! Would it be useful to provide a regression test?

23

An automatic reproducible regression tests would be nice. We currently don’t have anything in place to test this part of the codebase automatically

24

I’d like to use webtest but I get a conflict when building my testcase inside the jsoo tree:

Error: Conflict between the following libraries:
- "js_of_ocaml" in _build/default/lib/js_of_ocaml
- "js_of_ocaml" in /home/me/.opam/default/lib/js_of_ocaml
  -> required by library "webtest-js" in
     /home/me/.opam/default/lib/webtest-js
-> required by executable client in lib/tests/tyxml/dune:2
-> required by _build/default/lib/tests/tyxml/client.bc.js

Should I vendor this library?

25

You can vendor for now but ultimately,
I would prefer to limit dependencies.
It’s not clear to me that webtests gives us much here.
Also, could the selenium driver use JS instead of python ?
Maybe open a draft PR, it will be easier to discuss things