Help Test the New Odoc-3-Powered Package Documentation Pages

Ecosystem
,
8

Good work on the new features! They’ll make exploring package docs easier.

I noticed an issue when browsing the pages on mobile, the “Source” link looks like it is part of the signature:

image
image375×204 12.2 KB

This uses the exact same style as links which are part of the signature, and that can lead to unneeded confusion:
image
image375×294 17.9 KB

I fully understand focusing on the desktop experience over mobile for browsing the docs. But the above seems problematic enough to warrant a fix.

Diving into the CSS I noticed it is probably supposed to have a different color:

image
image460×397 36.3 KB

But there are two issues with this:

  • --source-link-color is unset
  • Even if it were set, its would be overridden by color: white from the .dark div.odoc a:not(.source_code a) selector.

I could fix the rendering by adding the following CSS rule:

.dark div.odoc a:not(.source_code a).source_link {
  color: #C14F1D;
}

image
image376×280 19.1 KB

However, even with the distinct color, I still think this layout is a bit confusing. I would consider moving this link to above or below the function signature, or also adding a distinct background color.